LGTM. Let's see CI results.

Thanks Dženan. Apparently there's still an OpenCL issue in SuperElastix/elastix to be fixed:

_deps/elx-src/Common/OpenCL/ITKimprovements/itkOpenCLLogger.h:72:23: error: ‘PriorityLevelType’ has not been declared

https://github.com/InsightSoftwareConsortium/ITKElastix/runs/1086581143#step:4:1976

I'll have a look!

@dzenanz @thewtex My pull request still appears to have some link errors. Which seems to be related to the fact that the SuperElastix/elastix project now distinguished between two CMake targets: elastix_exe and elastix_lib (as I committed with SuperElastix/elastix@3944a13 ). When an application wants to link to the elastix library, it must now specify "elastix_lib", instead of just "elastix".

Now it appears that "${Elastix-Test_LIBRARIES}" should be adjusted to specify "elastix_lib" instead of just "elastix", for this CreateTestDriver call:

Can you please tell me how to properly adjust "${Elastix-Test_LIBRARIES}"? I think it must evaluate to "elastix_lib;transformix_lib;ITKMetaIO;ITKTestKernel"

Since this is set, this might be sufficient:

list(APPEND Elastix-Test_LIBRARIES elastix_lib transformix_lib)
CreateTestDriver(Elastix "${Elastix-Test_LIBRARIES}" "${ElastixTests}" )

I looked around the code, and don't see how elastix.lib used to propagate to the executable. So the above suggestion is more of a guess.

@dzenanz Thanks for looking into this issue regarding those link errors. I think it is fixed now, by doing set(Elastix_LIBRARIES elastix_lib transformix_lib) in the root-level CMakeLists.

I'm currently looking into

/work/_skbuild/linux-x86_64-3.5/cmake-build/_deps/elx-src/Core/Kernel/elxElastixMain.h:33:10: fatal error: 'itkOpenCLContext.h' file not found
https://github.com/InsightSoftwareConsortium/ITKElastix/pull/58/checks?check_run_id=1096122268#step:4:2894

Please let me know if you have a clue! Note that 'itkOpenCLContext.h' is in Elastix, at https://github.com/SuperElastix/elastix/blob/develop/Common/OpenCL/ITKimprovements/itkOpenCLContext.h

Clue: OpenCL/ITKimprovements needs to be added to include directories, somewhere 😄

The above is somewhat of a joke, I am sure you can deduce that yourself. I looked a bit and don't have useful suggestions 😞

@dzenanz Thanks but why did you merge already? It was still in draft status, and it still has failures from build-test-cxx (ubuntu-18.04)!

I accidentally pushed to all repositories instead of pulling from all repositories.

I was searching for this PR right now!

I think you will have to create a new PR. Reusing the same branch in your fork is fine. Sorry for this 😢

Then what is the current status? Is it merged now? I don't see it being merged at https://github.com/InsightSoftwareConsortium/ITKElastix/commits/master

I quickly realized my mistake, and put master branch to point to the old commit. But it had a side-effect of closing this PR.

Please reference this PR in the new PR, in order to keep discussion history.

I quickly realized my mistake, and put master branch to point to the old commit. But it had a side-effect of closing this PR.

So it's a GitHub bug that it doesn't allow reopening the PR! 😸